From 31e4e8205a231b237452fd085a2a7261a7926040 Mon Sep 17 00:00:00 2001 From: zeripath Date: Mon, 23 Aug 2021 23:09:28 +0100 Subject: [PATCH] Add missing return to handleSettingRemoteAddrError (#16794) (#16795) Backport #16794 There is a missing return in handleSettingRemoteAddrError which means that the error page for repo settings is duplicately rendered. Fix #16771 Signed-off-by: Andrew Thornton Co-authored-by: techknowlogick --- routers/web/repo/setting.go | 1 + 1 file changed, 1 insertion(+) diff --git a/routers/web/repo/setting.go b/routers/web/repo/setting.go index 0a84f15bf0..38d551de92 100644 --- a/routers/web/repo/setting.go +++ b/routers/web/repo/setting.go @@ -742,6 +742,7 @@ func handleSettingRemoteAddrError(ctx *context.Context, err error, form *forms.R default: ctx.ServerError("Unknown error", err) } + return } ctx.RenderWithErr(ctx.Tr("repo.mirror_address_url_invalid"), tplSettingsOptions, form) }