From 4bf86e959475873841a1554bd5a6ccc2feb7e8e5 Mon Sep 17 00:00:00 2001 From: Lunny Xiao Date: Mon, 26 Aug 2024 10:37:31 -0700 Subject: [PATCH] Follow the old logic --- services/repository/transfer.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/services/repository/transfer.go b/services/repository/transfer.go index 597b4ebcc4..ec644f3f3a 100644 --- a/services/repository/transfer.go +++ b/services/repository/transfer.go @@ -47,11 +47,12 @@ func TransferOwnership(ctx context.Context, doer, newOwner *user_model.User, rep log.Error("lock.Lock(): %v", err) return fmt.Errorf("lock.Lock: %w", err) } - defer releaser() if err := transferOwnership(ctx, doer, newOwner.Name, repo); err != nil { + releaser() return err } + releaser() newRepo, err := repo_model.GetRepositoryByID(ctx, repo.ID) if err != nil { @@ -372,11 +373,12 @@ func ChangeRepositoryName(ctx context.Context, doer *user_model.User, repo *repo log.Error("lock.Lock(): %v", err) return fmt.Errorf("lock.Lock: %w", err) } - defer releaser() if err := changeRepositoryName(ctx, repo, newRepoName); err != nil { + releaser() return err } + releaser() repo.Name = newRepoName notify_service.RenameRepository(ctx, doer, repo, oldRepoName)