From 8c1bb7743784bb0f0754acc7f6855432fddca653 Mon Sep 17 00:00:00 2001
From: Lunny Xiao <xiaolunwen@gmail.com>
Date: Thu, 22 Dec 2022 21:09:35 +0800
Subject: [PATCH] Remove test session cache to reduce possible concurrent
problem (#22199)
---
tests/integration/integration_test.go | 10 ++--------
tests/integration/signout_test.go | 3 ---
2 files changed, 2 insertions(+), 11 deletions(-)
diff --git a/tests/integration/integration_test.go b/tests/integration/integration_test.go
index 3537409aeb..911d9ddf4c 100644
--- a/tests/integration/integration_test.go
+++ b/tests/integration/integration_test.go
@@ -209,8 +209,6 @@ func (s *TestSession) MakeRequestNilResponseHashSumRecorder(t testing.TB, req *h
const userPassword = "password"
-var loginSessionCache = make(map[string]*TestSession, 10)
-
func emptyTestSession(t testing.TB) *TestSession {
t.Helper()
jar, err := cookiejar.New(nil)
@@ -225,12 +223,8 @@ func getUserToken(t testing.TB, userName string) string {
func loginUser(t testing.TB, userName string) *TestSession {
t.Helper()
- if session, ok := loginSessionCache[userName]; ok {
- return session
- }
- session := loginUserWithPassword(t, userName, userPassword)
- loginSessionCache[userName] = session
- return session
+
+ return loginUserWithPassword(t, userName, userPassword)
}
func loginUserWithPassword(t testing.TB, userName, password string) *TestSession {
diff --git a/tests/integration/signout_test.go b/tests/integration/signout_test.go
index 0416930c67..0e822ac04e 100644
--- a/tests/integration/signout_test.go
+++ b/tests/integration/signout_test.go
@@ -21,7 +21,4 @@ func TestSignOut(t *testing.T) {
// try to view a private repo, should fail
req = NewRequest(t, "GET", "/user2/repo2")
session.MakeRequest(t, req, http.StatusNotFound)
-
- // invalidate cached cookies for user2, for subsequent tests
- delete(loginSessionCache, "user2")
}