You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
gitea/models
Lunny Xiao e8b6d28ab9
Fix bug hidden on CI and make ci failed if tests failure (#29254) (#29662)
Backport #29254 

The tests on migration tests failed but CI reports successfully


https://github.com/go-gitea/gitea/actions/runs/7364373807/job/20044685969#step:8:141

This PR will fix the bug on migrations and also the CI hidden behaviour.

The reason is on the Makefile

`GITEA_ROOT="$(CURDIR)" GITEA_CONF=tests/mysql.ini $(GO) test
$(GOTESTFLAGS) -tags='$(TEST_TAGS)' $(MIGRATE_TEST_PACKAGES)` will
return the error exit code.

But

`for pkg in $(shell $(GO) list
code.gitea.io/gitea/models/migrations/...); do \
GITEA_ROOT="$(CURDIR)" GITEA_CONF=tests/mysql.ini $(GO) test
$(GOTESTFLAGS) -tags '$(TEST_TAGS)' $$pkg; \
	done`

will not work.

---------

Co-authored-by: Giteabot <teabot@gitea.io>
3 months ago
..
actions Fix schedule tasks bugs (#28691) (#28780) 5 months ago
activities Avoid issue info panic (#29625) (#29632) 3 months ago
admin Next round of `db.DefaultContext` refactor (#27089) 9 months ago
asymkey Retry SSH key verification with additional CRLF if it failed (#28392) (#28464) 6 months ago
auth Fix bug when the linked account was disactived and list the linked accounts (#29263) 4 months ago
avatars Refactor system setting (#27000) (#27452) 8 months ago
db Avoid cycle-redirecting user/login page (#28636) (#28658) 5 months ago
dbfs Fix content holes in Actions task logs file (#25560) 12 months ago
fixtures Fix reverting a merge commit failing (#28794) (#28825) 5 months ago
git Fix `GetCommitStatuses` (#28787) (#28804) 5 months ago
issues Add missing database transaction for new issue (#29490) (#29607) 3 months ago
migrations Fix bug hidden on CI and make ci failed if tests failure (#29254) (#29662) 3 months ago
organization Another round of `db.DefaultContext` refactor (#27103) (#27262) 9 months ago
packages Fix incorrect relative/absolute URL usages (#29531) (#29547) 3 months ago
perm Users with `read` permission of pull requests can be assigned too (#27263) (#29372) 4 months ago
project Fix comment permissions (#28213) (#28216) 7 months ago
pull refactor some functions to support ctx as first parameter (#21878) 2 years ago
repo Users with `read` permission of pull requests can be assigned too (#27263) (#29372) 4 months ago
secret Refactor secrets modification logic (#26873) 9 months ago
shared/types Display owner of a runner as a tooltip instead of static text (#24377) 1 year ago
system Increase "version" when update the setting value to a same value as before (#28243) (#28244) 7 months ago
unit Use `Set[Type]` instead of `map[Type]bool/struct{}`. (#26804) 10 months ago
unittest Workaround to clean up old reviews on creating a new one (#28554) (#29264) 4 months ago
user Only use supported sort order for "explore/users" page (#29430) (#29443) 3 months ago
webhook Fix comment permissions (#28213) (#28216) 7 months ago
error.go Forbid removing the last admin user (#28337) (#28793) 5 months ago
fixture_generation.go Fix yaml test (#27297) (#27303) 9 months ago
fixture_test.go Fix yaml test (#27297) (#27303) 9 months ago
main_test.go move repository deletion to service layer (#26948) 9 months ago
org.go refactor some functions to support ctx as first parameter (#21878) 2 years ago
org_team.go Use db.WithTx for AddTeamMember to avoid ctx abuse (#27095) 9 months ago
org_team_test.go Reduce usage of `db.DefaultContext` (#27073) 9 months ago
org_test.go Implement FSFE REUSE for golang files (#21840) 2 years ago
repo.go Refactor system setting (#27000) (#27452) 8 months ago
repo_test.go Implement FSFE REUSE for golang files (#21840) 2 years ago
repo_transfer.go Next round of `db.DefaultContext` refactor (#27089) 9 months ago
repo_transfer_test.go Next round of `db.DefaultContext` refactor (#27089) 9 months ago