gitea/templates/repo
oliverpool 26653b196b
Store webhook event in database (#29145)
Refactor the webhook logic, to have the type-dependent processing happen
only in one place.

---

## Current webhook flow

1. An event happens
2. It is pre-processed (depending on the webhook type) and its body is
added to a task queue
3. When the task is processed, some more logic (depending on the webhook
type as well) is applied to make an HTTP request

This means that webhook-type dependant logic is needed in step 2 and 3.
This is cumbersome and brittle to maintain.

Updated webhook flow with this PR:
1. An event happens
2. It is stored as-is and added to a task queue
3. When the task is processed, the event is processed (depending on the
webhook type) to make an HTTP request

So the only webhook-type dependent logic happens in one place (step 3)
which should be much more robust.

## Consequences of the refactor

- the raw event must be stored in the hooktask (until now, the
pre-processed body was stored)
- to ensure that previous hooktasks are correctly sent, a
`payload_version` is added (version 1: the body has already been
pre-process / version 2: the body is the raw event)

So future webhook additions will only have to deal with creating an
http.Request based on the raw event (no need to adjust the code in
multiple places, like currently).

Moreover since this processing happens when fetching from the task
queue, it ensures that the queuing of new events (upon a `git push` for
instance) does not get slowed down by a slow webhook.

As a concrete example, the PR #19307 for custom webhooks, should be
substantially smaller:
- no need to change `services/webhook/deliver.go` 
- minimal change in `services/webhook/webhook.go` (add the new webhook
to the map)
- no need to change all the individual webhook files (since with this
refactor the `*webhook_model.Webhook` is provided as argument)
2024-03-07 23:18:38 +01:00
..
actions Remove unnecessary "Safe" modifier from templates (#29318) 2024-02-22 17:02:33 +00:00
branch Replace some gt- classes with tw- (#29570) 2024-03-04 03:33:20 +00:00
cite Update JS and PY dependencies (#27501) 2023-10-08 00:16:20 +00:00
code Add a link for the recently pushed branch notification (#29627) 2024-03-06 11:25:00 +00:00
diff Replace more gt- with tw-, update frontend docs (#29595) 2024-03-05 05:29:32 +00:00
editor Remove jQuery AJAX from the repo editor (#29636) 2024-03-07 07:28:33 +00:00
find Always use ctx.Locale.Tr inside templates (#27231) 2023-09-25 08:56:50 +00:00
graph Rework markup link rendering (#26745) 2024-01-15 08:49:24 +00:00
issue Replace more gt- with tw-, update frontend docs (#29595) 2024-03-05 05:29:32 +00:00
migrate Replace some gt- classes with tw- (#29570) 2024-03-04 03:33:20 +00:00
projects Use full width for project boards (#28225) 2023-11-27 17:43:52 +00:00
pulls Remove unnecessary "Safe" modifier from templates (#29318) 2024-02-22 17:02:33 +00:00
release Replace some gt- classes with tw- (#29570) 2024-03-04 03:33:20 +00:00
settings Store webhook event in database (#29145) 2024-03-07 23:18:38 +01:00
tag Fix more "locale" usages (#27259) 2023-09-25 20:42:40 +08:00
wiki Make wiki default branch name changable (#29603) 2024-03-06 14:26:32 +08:00
activity.tmpl Implement recent commits graph (#29210) 2024-02-24 10:22:51 +00:00
blame.tmpl Remove unnecessary "Str2html" modifier from templates (#29319) 2024-02-22 18:05:47 +00:00
branch_dropdown.tmpl Rework spellchecking, add lint-spell (#29106) 2024-02-09 03:59:39 +00:00
clone_buttons.tmpl Fix more "locale" usages (#27259) 2023-09-25 20:42:40 +08:00
clone_script.tmpl Fix URL calculation in clone input box (#29470) 2024-02-28 15:04:04 +00:00
code_frequency.tmpl Implement code frequency graph (#29191) 2024-02-23 23:41:24 +00:00
commit_load_branches_and_tags.tmpl Wrap contained tags and branches again (#29021) 2024-02-02 04:51:09 +00:00
commit_page.tmpl Replace more gt- with tw-, update frontend docs (#29595) 2024-03-05 05:29:32 +00:00
commit_status.tmpl Restore warning commit status (#27504) 2023-10-08 22:16:06 +00:00
commit_statuses.tmpl Show commit status for releases (#29149) 2024-02-19 10:27:05 +00:00
commits_list_small.tmpl Replace some gt- classes with tw- (#29570) 2024-03-04 03:33:20 +00:00
commits_list.tmpl Show View at this point in history for every commit (#29122) 2024-02-13 09:07:59 +01:00
commits_table.tmpl Replace some gt- classes with tw- (#29570) 2024-03-04 03:33:20 +00:00
commits.tmpl Always use ctx.Locale.Tr inside templates (#27231) 2023-09-25 08:56:50 +00:00
contributors.tmpl Deduplicate translations for contributors graph (#29256) 2024-02-19 12:47:38 +00:00
create_helper.tmpl Remove incorrect and unnecessary Escape from templates (#29394) 2024-02-25 14:02:20 +00:00
create.tmpl Remove unnecessary "Str2html" modifier from templates (#29319) 2024-02-22 18:05:47 +00:00
empty.tmpl Replace some gt- classes with tw- (#29570) 2024-03-04 03:33:20 +00:00
file_info.tmpl Show in Web UI if file is vendored and generated (#28620) 2024-01-24 13:51:37 +08:00
forks.tmpl Always use ctx.Locale.Tr inside templates (#27231) 2023-09-25 08:56:50 +00:00
graph.tmpl Fix more "locale" usages (#27259) 2023-09-25 20:42:40 +08:00
header.tmpl Replace some gt- classes with tw- (#29570) 2024-03-04 03:33:20 +00:00
home.tmpl Replace some gt- classes with tw- (#29570) 2024-03-04 03:33:20 +00:00
icon.tmpl Tweak repo header (#29134) 2024-02-15 16:52:21 +00:00
latest_commit.tmpl Show latest commit for file (#28067) 2024-01-15 17:42:15 +01:00
navbar.tmpl Implement recent commits graph (#29210) 2024-02-24 10:22:51 +00:00
packages.tmpl Fix inconsistent user profile layout across tabs (#25625) 2023-07-06 18:59:24 +00:00
pulse.tmpl Remove unnecessary "Safe" modifier from templates (#29318) 2024-02-22 17:02:33 +00:00
recent_commits.tmpl Implement recent commits graph (#29210) 2024-02-24 10:22:51 +00:00
release_tag_header.tmpl Fix a bug returning 404 when display a single tag with no release (#29466) 2024-03-02 14:03:39 +00:00
search_name.tmpl Clean template/helper.go (#23922) 2023-04-07 03:31:41 -04:00
search.tmpl Fix wrong line number in code search result (#29260) 2024-03-06 07:24:43 +00:00
shabox_badge.tmpl cleanup locale function usage (#27227) 2023-09-24 20:31:58 +00:00
star_unstar.tmpl Refactor star/watch button (#29576) 2024-03-04 12:56:34 +00:00
sub_menu.tmpl Enable followCursor for language stats bar (#27713) 2023-10-22 13:06:04 +00:00
unicode_escape_prompt.tmpl Replace some gt- classes with tw- (#29570) 2024-03-04 03:33:20 +00:00
upload.tmpl Always use ctx.Locale.Tr inside templates (#27231) 2023-09-25 08:56:50 +00:00
user_cards.tmpl Remove unnecessary "Safe" modifier from templates (#29318) 2024-02-22 17:02:33 +00:00
view_file.tmpl Replace some gt- classes with tw- (#29570) 2024-03-04 03:33:20 +00:00
view_list.tmpl Fix elipsis button not working if the last commit loading is deferred (#29544) 2024-03-02 19:31:59 +00:00
watch_unwatch.tmpl Refactor star/watch button (#29576) 2024-03-04 12:56:34 +00:00
watchers.tmpl Fix user-cards format (#24428) 2023-04-29 15:43:01 -04:00