Mirrors/gitea
1
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2024-09-01 14:56:30 +00:00
Code Issues Packages Projects Releases Wiki Activity
7d75eede04
gitea/modules/git
History
zeripath 148a417774
Prevent off-by-one error on comments on newly appended lines (#18029) (#18035) 
* Prevent off-by-one error on comments on newly appended lines (#18029)

Backport #18029

There was a bug in CutDiffAroundLine whereby if a file without a terminal new line
has a patch which appends lines to it and a comment is placed on one of those lines
the comment diff will be a line out of place.

This fixes CutDiffAroundLine to simply ignore the missing terminal newline - however,
we should really improve this rendering to add a marker to say that there was a
previously missing terminal newline.

Fix #17875

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Apply suggestions from code review

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2021-12-20 11:38:58 -05:00
..
pipeline Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
tests/repos
batch_reader.go Prevent hang in git cat-file if the repository is not a valid repository (Partial #17991) (#17992) 2021-12-17 10:08:00 +08:00
blame_test.go
blame.go
blob_gogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
blob_nogogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
blob_test.go
blob.go Read expected buffer size (#17409) (#17430) 2021-10-25 17:46:56 +01:00
command_test.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
command.go
commit_convert_gogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
commit_info_gogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
commit_info_nogogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
commit_info_test.go
commit_info.go
commit_reader.go
commit_test.go
commit.go
diff_test.go Prevent off-by-one error on comments on newly appended lines (#18029) (#18035) 2021-12-20 11:38:58 -05:00
diff.go Prevent off-by-one error on comments on newly appended lines (#18029) (#18035) 2021-12-20 11:38:58 -05:00
error.go
git_test.go
git.go Disable core.protectNTFS (#17300) (#17302) 2021-10-13 23:02:45 +03:00
hook.go
last_commit_cache_gogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
last_commit_cache_nogogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
last_commit_cache.go
lfs.go
log_name_status.go Fix missing close in WalkGitLog (#17008) (#17009) 2021-09-10 17:46:06 +08:00
notes_gogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
notes_nogogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
notes_test.go
notes.go
parse_gogit_test.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
parse_gogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
parse_nogogit_test.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
parse_nogogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
README.md
ref.go
remote.go
repo_archive.go
repo_attribute.go
repo_base_gogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
repo_base_nogogit.go Prevent hang in git cat-file if the repository is not a valid repository (Partial #17991) (#17992) 2021-12-17 10:08:00 +08:00
repo_blame.go
repo_blob_gogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
repo_blob_nogogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
repo_blob_test.go
repo_blob.go
repo_branch_gogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
repo_branch_nogogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
repo_branch_test.go
repo_branch.go
repo_commit_gogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
repo_commit_nogogit.go Prevent hang in git cat-file if the repository is not a valid repository (Partial #17991) (#17992) 2021-12-17 10:08:00 +08:00
repo_commit_test.go
repo_commit.go
repo_commitgraph_gogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
repo_compare_test.go
repo_compare.go
repo_gpg.go
repo_hook.go
repo_index.go
repo_language_stats_gogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
repo_language_stats_nogogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
repo_language_stats.go
repo_object.go
repo_ref_gogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
repo_ref_nogogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
repo_ref_test.go
repo_ref.go
repo_stats_test.go
repo_stats.go
repo_tag_gogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
repo_tag_nogogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
repo_tag_test.go
repo_tag.go
repo_test.go
repo_tree_gogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
repo_tree_nogogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
repo_tree.go
repo.go
sha1_gogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
sha1_nogogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
sha1.go
signature_gogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
signature_nogogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
signature.go
submodule_test.go
submodule.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
tag_test.go
tag.go
tree_blob_gogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
tree_blob_nogogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
tree_blob.go
tree_entry_gogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
tree_entry_mode.go
tree_entry_nogogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
tree_entry_test.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
tree_entry.go
tree_gogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
tree_nogogit.go Fix golangci-lint warnings (#17598 et al) (#17668) 2021-11-16 20:38:49 +00:00
tree.go
utils_test.go
utils.go

README.md

Git Module

This module is merged from https://github.com/go-gitea/git which is a Go module to access Git through shell commands. Now it's a part of gitea's main repository for easier pull request.