1
0
mirror of https://github.com/go-gitea/gitea.git synced 2024-09-01 14:56:30 +00:00
gitea/models
YR Chen b1dae9f2c8
Move from max( id ) to max( index ) for latest commit statuses () ()
Backport https://github.com/go-gitea/gitea/pull/30076.

This PR replaces the use of `max( id )`, and instead using ``max(
`index` )`` for determining the latest commit status. Building business
logic over an `auto_increment` primary key like `id` is risky and
there’re already plenty of discussions on the Internet.

There‘s no guarantee for `auto_increment` values to be monotonic,
especially upon failures or with a cluster. In the specific case, we met
the problem of commit statuses being outdated when using TiDB as the
database. As [being
documented](https://docs.pingcap.com/tidb/stable/auto-increment),
`auto_increment` values assigned to an `insert` statement will only be
monotonic on a per server (node) basis.

Closes .
2024-03-28 16:29:38 +00:00
..
actions Make runs-on support variable expression () () 2024-03-14 10:19:01 +08:00
activities Performance improvements for pull request list page () () 2024-03-22 09:58:04 +08:00
admin Next round of db.DefaultContext refactor () 2023-09-16 14:39:12 +00:00
asymkey Retry SSH key verification with additional CRLF if it failed () () 2023-12-14 12:50:26 +08:00
auth Fix bug when the linked account was disactived and list the linked accounts () 2024-02-19 15:23:47 +00:00
avatars Refactor system setting () () 2023-10-05 10:37:59 +00:00
db Fix misuse of TxContext () () 2024-03-25 07:22:09 +00:00
dbfs Fix content holes in Actions task logs file () 2023-06-28 19:07:29 +02:00
fixtures Fix template error when comment review doesn't exist () () 2024-03-19 15:00:01 +08:00
git Move from max( id ) to max( index ) for latest commit statuses () () 2024-03-28 16:29:38 +00:00
issues Load attachments for code comments () () 2024-03-27 16:06:23 +08:00
migrations Fix bug hidden on CI and make ci failed if tests failure () () 2024-03-09 09:44:02 +00:00
organization Respect DEFAULT_ORG_MEMBER_VISIBLE setting when adding creator to org () () 2024-03-24 06:38:31 +01:00
packages Fix incorrect relative/absolute URL usages () () 2024-03-02 18:00:15 +00:00
perm Users with read permission of pull requests can be assigned too () () 2024-02-24 17:42:33 +01:00
project Fix comment permissions () () 2023-11-25 23:43:23 +00:00
pull refactor some functions to support ctx as first parameter () 2022-12-03 10:48:26 +08:00
repo Users with read permission of pull requests can be assigned too () () 2024-02-24 17:42:33 +01:00
secret Make runs-on support variable expression () () 2024-03-14 10:19:01 +08:00
shared/types Display owner of a runner as a tooltip instead of static text () 2023-05-12 08:43:27 +00:00
system Increase "version" when update the setting value to a same value as before () () 2023-11-28 01:58:39 +08:00
unit Use Set[Type] instead of map[Type]bool/struct{}. () 2023-08-30 06:55:25 +00:00
unittest Workaround to clean up old reviews on creating a new one () () 2024-02-19 16:48:58 +00:00
user Fix user id column case () () 2024-03-17 13:51:15 +00:00
webhook Fix comment permissions () () 2023-11-25 23:43:23 +00:00
error.go Forbid removing the last admin user () () 2024-01-16 01:51:46 +00:00
fixture_generation.go Fix yaml test () () 2023-09-27 15:05:35 +08:00
fixture_test.go Fix yaml test () () 2023-09-27 15:05:35 +08:00
main_test.go move repository deletion to service layer () 2023-09-08 04:51:15 +00:00
org_team_test.go Reduce usage of db.DefaultContext () 2023-09-14 17:09:32 +00:00
org_team.go Use db.WithTx for AddTeamMember to avoid ctx abuse () 2023-09-16 12:54:23 +00:00
org_test.go Implement FSFE REUSE for golang files () 2022-11-27 18:20:29 +00:00
org.go refactor some functions to support ctx as first parameter () 2022-12-03 10:48:26 +08:00
repo_test.go Implement FSFE REUSE for golang files () 2022-11-27 18:20:29 +00:00
repo_transfer_test.go Next round of db.DefaultContext refactor () 2023-09-16 14:39:12 +00:00
repo_transfer.go Next round of db.DefaultContext refactor () 2023-09-16 14:39:12 +00:00
repo.go Refactor system setting () () 2023-10-05 10:37:59 +00:00