gitea/cmd
zeripath 06f968d662
Fix hard-coded timeout and error panic in API archive download endpoint (#20925) (#21051)
Backport #20925

This commit updates the `GET /api/v1/repos/{owner}/{repo}/archive/{archive}`
endpoint which prior to this PR had a couple of issues.

1. The endpoint had a hard-coded 20s timeout for the archiver to complete after
   which a 500 (Internal Server Error) was returned to client. For a scripted
   API client there was no clear way of telling that the operation timed out and
   that it should retry.

2. Whenever the timeout _did occur_, the code used to panic. This was caused by
   the API endpoint "delegating" to the same call path as the web, which uses a
   slightly different way of reporting errors (HTML rather than JSON for
   example).

   More specifically, `api/v1/repo/file.go#GetArchive` just called through to
   `web/repo/repo.go#Download`, which expects the `Context` to have a `Render`
   field set, but which is `nil` for API calls. Hence, a `nil` pointer error.

The code addresses (1) by dropping the hard-coded timeout. Instead, any
timeout/cancelation on the incoming `Context` is used.

The code addresses (2) by updating the API endpoint to use a separate call path
for the API-triggered archive download. This avoids producing HTML-errors on
errors (it now produces JSON errors).

Signed-off-by: Peter Gardfjäll <peter.gardfjall.work@gmail.com>

Signed-off-by: Peter Gardfjäll <peter.gardfjall.work@gmail.com>
Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: Peter Gardfjäll <peter.gardfjall.work@gmail.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2022-09-06 07:54:47 +01:00
..
admin_auth_ldap_test.go format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
admin_auth_ldap.go Add LDAP group sync to Teams, fixes #1395 (#16299) 2022-02-11 22:24:58 +08:00
admin.go Move some repository related code into sub package (#19711) 2022-06-06 16:01:49 +08:00
cert.go format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
cmd.go fix: some typos (#19956) 2022-06-13 15:34:46 +08:00
convert.go Improve install code to avoid low-level mistakes. (#17779) 2021-12-01 15:50:01 +08:00
docs.go Fix offBy1 errors (#17606) 2021-11-14 10:11:49 +02:00
doctor.go Disable doctor logging on panic (#20847) (#20898) 2022-08-24 15:04:41 +01:00
dump_repo.go Make sure repo_dir is an empty directory or doesn't exist before 'dump-repo' (#20205) (#20370) 2022-07-15 11:12:52 +08:00
dump.go Dump should only copy regular files and symlink regular files (#20015) (#20021) 2022-06-19 10:05:31 +08:00
embedded_stub.go Remove legacy +build: constraint (#19582) 2022-05-02 23:22:45 +08:00
embedded.go Remove legacy +build: constraint (#19582) 2022-05-02 23:22:45 +08:00
generate.go Add asymmetric JWT signing (#16010) 2021-06-17 23:56:46 +02:00
hook_test.go Add agit flow support in gitea (#14295) 2021-07-28 17:42:56 +08:00
hook.go Remove legacy git code (ver < 2.0), fine tune markup tests (#19930) 2022-06-16 23:47:44 +08:00
keys.go Second attempt at preventing zombies (#16326) 2021-07-14 10:43:13 -04:00
mailer.go Improve install code to avoid low-level mistakes. (#17779) 2021-12-01 15:50:01 +08:00
main_test.go Add migrate repo archiver and packages storage support on command line (#20757) (#20806) 2022-08-18 09:27:56 +08:00
manager_logging.go Remove legacy unknwon/com package (#19298) 2022-04-02 00:34:57 +08:00
manager.go Add Goroutine stack inspector to admin/monitor (#19207) 2022-03-31 19:01:43 +02:00
migrate_storage_test.go Add migrate repo archiver and packages storage support on command line (#20757) (#20806) 2022-08-18 09:27:56 +08:00
migrate_storage.go Fix hard-coded timeout and error panic in API archive download endpoint (#20925) (#21051) 2022-09-06 07:54:47 +01:00
migrate.go Improve install code to avoid low-level mistakes. (#17779) 2021-12-01 15:50:01 +08:00
restore_repo.go Fix cli command restore-repo: "units" should be parsed as cli.String (#20183) (#20187) 2022-07-01 17:16:59 +02:00
serv.go Move some code into models/git (#19879) 2022-06-12 23:51:54 +08:00
web_acme.go Update go deps (#19665) 2022-05-10 12:32:42 +02:00
web_graceful.go Make SSL cipher suite configurable (#17440) 2021-11-20 01:12:43 -05:00
web_https.go Add user settings key/value DB table (#16834) 2021-11-22 04:47:23 -05:00
web.go Add fgprof pprof profiler (#20005) 2022-06-18 11:04:52 +01:00