Browse Source

Ignore --external-downloader-args if --external-downloader was rejected

... and generate warning
pull/21837/merge
dirkf 4 months ago
parent
commit
49c5293014
  1. 11
      youtube_dl/YoutubeDL.py
  2. 3
      youtube_dl/downloader/__init__.py

11
youtube_dl/YoutubeDL.py

@ -1906,8 +1906,17 @@ class YoutubeDL(object): @@ -1906,8 +1906,17 @@ class YoutubeDL(object):
if not self.params.get('skip_download', False):
try:
def checked_get_suitable_downloader(info_dict, params):
ed_args = params.get('external_downloader_args')
dler = get_suitable_downloader(info_dict, params)
if ed_args and not params.get('external_downloader_args'):
# external_downloader_args was cleared because external_downloader was rejected
self.report_warning('Requested external downloader cannot be used: '
'ignoring --external-downloader-args.')
return dler
def dl(name, info):
fd = get_suitable_downloader(info, self.params)(self, self.params)
fd = checked_get_suitable_downloader(info, self.params)(self, self.params)
for ph in self._progress_hooks:
fd.add_progress_hook(ph)
if self.params.get('verbose'):

3
youtube_dl/downloader/__init__.py

@ -50,6 +50,9 @@ def _get_suitable_downloader(info_dict, params={}): @@ -50,6 +50,9 @@ def _get_suitable_downloader(info_dict, params={}):
ed = get_external_downloader(external_downloader)
if ed.can_download(info_dict):
return ed
# Avoid using unwanted args since external_downloader was rejected
if params.get('external_downloader_args'):
params['external_downloader_args'] = None
protocol = info_dict['protocol']
if protocol.startswith('m3u8') and info_dict.get('is_live'):

Loading…
Cancel
Save