From b2da56b1ca2d7ec640d013be0ed30ca50394ab0b Mon Sep 17 00:00:00 2001 From: Jonathan Bayer Date: Sat, 3 Sep 2022 18:03:01 -0400 Subject: [PATCH] A few more edits --- Source/ConformalDecals/ModuleConformalDecal.cs | 5 +++-- Source/ConformalDecals/ModuleConformalFlag.cs | 4 +--- Source/ConformalDecals/ModuleConformalText.cs | 2 -- 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/Source/ConformalDecals/ModuleConformalDecal.cs b/Source/ConformalDecals/ModuleConformalDecal.cs index c8a9abd..d1c77ea 100644 --- a/Source/ConformalDecals/ModuleConformalDecal.cs +++ b/Source/ConformalDecals/ModuleConformalDecal.cs @@ -283,7 +283,7 @@ namespace ConformalDecals { } } - public void OnDestroy() { + public void OnDestroy() { // remove GameEvents if (HighLogic.LoadedSceneIsEditor) { GameEvents.onEditorPartEvent.Remove(OnEditorEvent); @@ -440,7 +440,8 @@ namespace ConformalDecals { // update projection foreach (var target in _targets) { - target.Project(_orthoMatrix, decalProjectorTransform, _boundsRenderer.bounds, useBaseNormal); + if (target != null) + target.Project(_orthoMatrix, decalProjectorTransform, _boundsRenderer.bounds, useBaseNormal); } } else { diff --git a/Source/ConformalDecals/ModuleConformalFlag.cs b/Source/ConformalDecals/ModuleConformalFlag.cs index 18f5446..73df416 100644 --- a/Source/ConformalDecals/ModuleConformalFlag.cs +++ b/Source/ConformalDecals/ModuleConformalFlag.cs @@ -53,9 +53,7 @@ namespace ConformalDecals { // Unregister flag change event GameEvents.onMissionFlagSelect.Remove(OnEditorFlagSelected); } - - //base.OnDestroy(); - } + } [KSPEvent(guiActive = false, guiActiveEditor = true, guiName = "#LOC_ConformalDecals_gui-select-flag")] public void SelectFlag() { diff --git a/Source/ConformalDecals/ModuleConformalText.cs b/Source/ConformalDecals/ModuleConformalText.cs index d7d213f..c1388ef 100644 --- a/Source/ConformalDecals/ModuleConformalText.cs +++ b/Source/ConformalDecals/ModuleConformalText.cs @@ -227,8 +227,6 @@ namespace ConformalDecals { if (_textEntryController != null) _textEntryController.Close(); if (_fillColorPickerController != null) _fillColorPickerController.Close(); if (_outlineColorPickerController != null) _outlineColorPickerController.Close(); - - //base.OnDestroy(); } protected override void OnDetach() {