drewcassidy/KSP-Conformal-Decals
1
0
Fork 0
mirror of https://github.com/drewcassidy/KSP-Conformal-Decals.git synced 2024-09-01 18:23:54 +00:00
Code Issues Releases Wiki Activity

better null checking

Browse Source
This commit is contained in:
Andrew Cassidy 2022-10-31 00:05:31 -07:00
parent ece9d959fd
commit d3388a4dad
1 changed files with 5 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
Source/ConformalDecals/ModuleConformalDecal.cs
View File

@ -577,20 +577,11 @@ namespace ConformalDecals {
public void Render(Camera camera) { public void Render(Camera camera) {
if (!_isAttached) return; if (!_isAttached) return;
try { // render on each target object
// render on each target object foreach (var target in _targets) {
foreach (var target in _targets) { if (ReferenceEquals(target.target, null)) _targets.Remove(target);
target.Render(_decalMaterial, part.mpb, camera); else target.Render(_decalMaterial, part.mpb, camera);
}
} catch (NullReferenceException) {
// catch any NREs and purge null transforms from the target list
// comparing Transform to null is expensive, but a try-catch block is much cheaper
foreach (var target in _targets) {
if (target.target == null) {
_targets.Remove(target);
}
}
} }
} }
} }