I hate bash

### Fixed

- Fixed flag decals sometimes not respecting image aspect ratio

.github/workflows/ksp-publish.yml

@@ -6,15 +6,15 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
 
       - name: Setup Python
-        uses: actions/setup-python@v2
+        uses: actions/setup-python@v5
         with:
-          python-version: '3.x'
+          python-version: '3.12'
 
       - name: Setup .NET Core SDK
-        uses: actions/setup-dotnet@v1.7.2
+        uses: actions/setup-dotnet@v4.0.0
         with:
           dotnet-version: '6.0.x'
 
@@ -25,7 +25,7 @@ jobs:
 
       - name: Generate Version Info
         run: |
-          echo "VERSION_TITLE=$(yaclog show -n)" >> $GITHUB_ENV
+          yaclog show
           python Scripts/version.py
           yaclog-ksp -n "Conformal Decals"
 
@@ -46,7 +46,7 @@ jobs:
 
       - name: Download KSP Dependencies
         run: |
-          wget http://taniwha.org/~bill/Shabby_v0.3.0.zip
+          wget https://pileof.rocks/KSP/Shabby_v0.3.0.zip
           wget https://ksp.sarbian.com/jenkins/job/ModuleManager/161/artifact/ModuleManager.4.2.1.dll
           wget https://github.com/blowfishpro/B9PartSwitch/releases/download/v2.19.0/B9PartSwitch_v2.19.0.zip
           wget https://github.com/KSPModdingLibs/HarmonyKSP/releases/download/2.0.4.0/HarmonyKSP_2.0.4.0_for_KSP1.8+.zip
@@ -59,22 +59,22 @@ jobs:
           mv HarmonyKSP/GameData/000_Harmony GameData/
 
       - name: Upload Unbundled Build
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: ConformalDecals-unbundled
           path: |
-            GameData/ConformalDecals 
+            GameData/ConformalDecals/
             README.md 
             CHANGELOG.md 
             LICENSE-ART.md 
             LICENSE-SOURCE.md
 
       - name: Upload Bundled Build
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: ConformalDecals
           path: |
-            GameData
+            GameData/
             README.md 
             CHANGELOG.md 
             LICENSE-ART.md 
@@ -87,12 +87,12 @@ jobs:
     if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags')
     
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
 
       - name: Setup Python
-        uses: actions/setup-python@v2
+        uses: actions/setup-python@v5
         with:
-          python-version: '3.x'
+          python-version: '3.12'
 
       - name: Install Python Tools
         run: |
@@ -102,13 +102,14 @@ jobs:
       - name: Get version name and body
         run: |
           echo "VERSION_TITLE=$(yaclog show -n)" >> $GITHUB_ENV
-          echo "$(yaclog show -mb)" >> RELEASE.md
+          yaclog show
 
       - name: Download Build Artifacts
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
 
       - name: Zip Download Packages
         run: |
+          set -u
           mkdir bundled
           mkdir unbundled
           zip -r bundled/ConformalDecals-$VERSION_TITLE.zip ConformalDecals/*
@@ -117,6 +118,7 @@ jobs:
 
       - name: Publish to Spacedock
         run: |
+          set -u
           curl -F "username=drewcassidy" -F "password=${{ secrets.SPACEDOCK_PASS }}" \
             -c ./cookies "https://spacedock.info/api/login"
           curl -c ./cookies -b ./cookies \
@@ -128,12 +130,13 @@ jobs:
             "https://spacedock.info/api/mod/2451/update"
 
       - name: Publish to Github
-        uses: softprops/action-gh-release@v1
-        with:
-          files: |
+        run: |
+          set -u
+          gh release create ${{ github.ref_name }} \
+            --notes "$(yaclog show -mb)" \
+            --title "Version $VERSION_TITLE" \
             bundled/ConformalDecals-*.zip 
             ConformalDecals/GameData/ConformalDecals/Versioning/ConformalDecals.version
-          name: Conformal Decals ${{ env.VERSION_TITLE }}
-          body_path: RELEASE.md
+
         env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

CHANGELOG.md

@@ -8,6 +8,13 @@ All notable changes to this project will be documented in this file
 | website | https://forum.kerbalspaceprogram.com/index.php?/topic/194802-18-111-conformal-decals |
 | author  | Andrew Cassidy                                                                       |
 
+## 0.2.13 - 2024-05-17
+
+### Fixed
+
+- Fixed flag decals sometimes not respecting image aspect ratio
+
+
 ## 0.2.12 - 2022-10-31
 
 ### Changed

README.md

@@ -8,7 +8,7 @@ Conformal Decals adds a set of decal stickers to KSP, as well as providing a fra
 ## Dependencies
 
 Required:
-- KSP (1.8.x to 1.10.x)
+- KSP (1.8.x to 1.12.x)
 - B9 Part Switch (2.18.0). Bundled with release.
 - ModuleManager (4.1.4). Bundled with release.
 - Shabby (0.2.0 unofficial build). Bundled with release.

Source/ConformalDecals/ModuleConformalDecal.cs

@@ -250,6 +250,7 @@ namespace ConformalDecals {
             if (HighLogic.LoadedSceneIsEditor) {
                 GameEvents.onEditorPartEvent.Add(OnEditorEvent);
                 GameEvents.onVariantApplied.Add(OnVariantApplied);
+                GameEvents.onEditorUndo.Add(OnEditorUndo);
 
                 UpdateTweakables();
             }
@@ -287,6 +288,7 @@ namespace ConformalDecals {
             if (HighLogic.LoadedSceneIsEditor) {
                 GameEvents.onEditorPartEvent.Remove(OnEditorEvent);
                 GameEvents.onVariantApplied.Remove(OnVariantApplied);
+                GameEvents.onEditorUndo.Remove(OnEditorUndo);
             }
 
             if (HighLogic.LoadedSceneIsFlight) {
@@ -350,6 +352,10 @@ namespace ConformalDecals {
             }
         }
 
+        protected void OnEditorUndo(ShipConstruct sc) {
+            UpdateTargets();
+        }
+
         protected void OnPartWillDie(Part willDie) {
             if (willDie == part.parent) {
                 this.Log("Parent part about to be destroyed! Killing decal part.");

Source/ConformalDecals/ModuleConformalFlag.cs

@@ -114,6 +114,8 @@ namespace ConformalDecals {
                 var ratio = DecalConfig.AspectRatios[textureURL];
                 this.Log($"Overriding aspect ratio for {textureURL} with {ratio}");
                 textureProperty.AspectRatio = ratio;
+            } else {
+                textureProperty.AspectRatio = -1.0f;
             }
 
             UpdateMaterials();